Skip to content

[StorageDiscovery] Generated to support 2026-10-01-preview service version - #30276

Open
Amanda Nguyen (amnguye) wants to merge 7 commits into
Azure:mainfrom
amnguye:feature/storagediscovery/2026-10-01-preview
Open

Amanda Nguyen (amnguye) wants to merge 7 commits into
Azure:mainfrom
amnguye:feature/storagediscovery/2026-10-01-preview

Conversation

@amnguye

@amnguye Amanda Nguyen (amnguye) commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ❌ Action needed

Tests
❌ 14/20
️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.StorageDiscovery
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzStorageDiscoveryWorkspace Get-AzStorageDiscoveryWorkspace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStorageDiscoveryWorkspace Get-AzStorageDiscoveryWorkspace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzStorageDiscoveryScopeObject New-AzStorageDiscoveryScopeObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzStorageDiscoveryWorkspace Get-AzStorageDiscoveryWorkspace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStorageDiscoveryWorkspace Get-AzStorageDiscoveryWorkspace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzStorageDiscoveryScopeObject New-AzStorageDiscoveryScopeObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
❌Help Example Check
❌PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel.
❌ New-AzStorageDiscoveryWorkspace 2 3 Invalid_Parameter_Name New-AzStorageDiscoveryWorkspace -CapacityDetailStatus is not a valid parameter name. -CapacityDetailStatus Check validity of the parameter -CapacityDetailStatus.
❌ New-AzStorageDiscoveryWorkspace 2 3 Invalid_Parameter_Name New-AzStorageDiscoveryWorkspace -AzureBlobStoragePrefixConfiguration is not a valid parameter name. -AzureBlobStoragePrefixConfiguration Check validity of the parameter -AzureBlobStoragePrefixConfiguration.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel1,$DiscoveryScopeLevel2 is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel1,$DiscoveryScopeLevel2.
⚠️ Update-AzStorageDiscoveryWorkspace 2 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ Update-AzStorageDiscoveryWorkspace 2 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
❌ Update-AzStorageDiscoveryWorkspace 2 2 Invalid_Parameter_Name Update-AzStorageDiscoveryWorkspace -CapacityDetailStatus is not a valid parameter name. -CapacityDetailStatus Check validity of the parameter -CapacityDetailStatus.
❌ Update-AzStorageDiscoveryWorkspace 2 2 Invalid_Parameter_Name Update-AzStorageDiscoveryWorkspace -AzureBlobStoragePrefixConfiguration is not a valid parameter name. -AzureBlobStoragePrefixConfiguration Check validity of the parameter -AzureBlobStoragePrefixConfiguration.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel.
❌ New-AzStorageDiscoveryWorkspace 2 3 Invalid_Parameter_Name New-AzStorageDiscoveryWorkspace -CapacityDetailStatus is not a valid parameter name. -CapacityDetailStatus Check validity of the parameter -CapacityDetailStatus.
❌ New-AzStorageDiscoveryWorkspace 2 3 Invalid_Parameter_Name New-AzStorageDiscoveryWorkspace -AzureBlobStoragePrefixConfiguration is not a valid parameter name. -AzureBlobStoragePrefixConfiguration Check validity of the parameter -AzureBlobStoragePrefixConfiguration.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel1,$DiscoveryScopeLevel2 is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel1,$DiscoveryScopeLevel2.
⚠️ Update-AzStorageDiscoveryWorkspace 2 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ Update-AzStorageDiscoveryWorkspace 2 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
❌ Update-AzStorageDiscoveryWorkspace 2 2 Invalid_Parameter_Name Update-AzStorageDiscoveryWorkspace -CapacityDetailStatus is not a valid parameter name. -CapacityDetailStatus Check validity of the parameter -CapacityDetailStatus.
❌ Update-AzStorageDiscoveryWorkspace 2 2 Invalid_Parameter_Name Update-AzStorageDiscoveryWorkspace -AzureBlobStoragePrefixConfiguration is not a valid parameter name. -AzureBlobStoragePrefixConfiguration Check validity of the parameter -AzureBlobStoragePrefixConfiguration.
❌Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel.
❌ New-AzStorageDiscoveryWorkspace 2 3 Invalid_Parameter_Name New-AzStorageDiscoveryWorkspace -CapacityDetailStatus is not a valid parameter name. -CapacityDetailStatus Check validity of the parameter -CapacityDetailStatus.
❌ New-AzStorageDiscoveryWorkspace 2 3 Invalid_Parameter_Name New-AzStorageDiscoveryWorkspace -AzureBlobStoragePrefixConfiguration is not a valid parameter name. -AzureBlobStoragePrefixConfiguration Check validity of the parameter -AzureBlobStoragePrefixConfiguration.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel1,$DiscoveryScopeLevel2 is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel1,$DiscoveryScopeLevel2.
⚠️ Update-AzStorageDiscoveryWorkspace 2 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ Update-AzStorageDiscoveryWorkspace 2 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
❌ Update-AzStorageDiscoveryWorkspace 2 2 Invalid_Parameter_Name Update-AzStorageDiscoveryWorkspace -CapacityDetailStatus is not a valid parameter name. -CapacityDetailStatus Check validity of the parameter -CapacityDetailStatus.
❌ Update-AzStorageDiscoveryWorkspace 2 2 Invalid_Parameter_Name Update-AzStorageDiscoveryWorkspace -AzureBlobStoragePrefixConfiguration is not a valid parameter name. -AzureBlobStoragePrefixConfiguration Check validity of the parameter -AzureBlobStoragePrefixConfiguration.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ New-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable New-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -ResourceGroupName $ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $ResourceGroupName.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ New-AzStorageDiscoveryWorkspace 2 3 Unassigned_Variable New-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel.
❌ New-AzStorageDiscoveryWorkspace 2 3 Invalid_Parameter_Name New-AzStorageDiscoveryWorkspace -CapacityDetailStatus is not a valid parameter name. -CapacityDetailStatus Check validity of the parameter -CapacityDetailStatus.
❌ New-AzStorageDiscoveryWorkspace 2 3 Invalid_Parameter_Name New-AzStorageDiscoveryWorkspace -AzureBlobStoragePrefixConfiguration is not a valid parameter name. -AzureBlobStoragePrefixConfiguration Check validity of the parameter -AzureBlobStoragePrefixConfiguration.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
⚠️ Update-AzStorageDiscoveryWorkspace 1 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -WorkspaceRoot $DiscoveryScopeLevel1,$DiscoveryScopeLevel2 is a null-valued parameter value. -WorkspaceRoot Assign value for $DiscoveryScopeLevel1,$DiscoveryScopeLevel2.
⚠️ Update-AzStorageDiscoveryWorkspace 2 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -Name $workSpaceName is a null-valued parameter value. -Name Assign value for $workSpaceName.
⚠️ Update-AzStorageDiscoveryWorkspace 2 2 Unassigned_Variable Update-AzStorageDiscoveryWorkspace -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
❌ Update-AzStorageDiscoveryWorkspace 2 2 Invalid_Parameter_Name Update-AzStorageDiscoveryWorkspace -CapacityDetailStatus is not a valid parameter name. -CapacityDetailStatus Check validity of the parameter -CapacityDetailStatus.
❌ Update-AzStorageDiscoveryWorkspace 2 2 Invalid_Parameter_Name Update-AzStorageDiscoveryWorkspace -AzureBlobStoragePrefixConfiguration is not a valid parameter name. -AzureBlobStoragePrefixConfiguration Check validity of the parameter -AzureBlobStoragePrefixConfiguration.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Test
❌PowerShell Core - Linux
❌PowerShell Core - MacOS
❌PowerShell Core - Windows
❌Windows PowerShell - Windows

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI balanced review requested due to automatic review settings October 9, 2026 05:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot AI balanced review requested due to automatic review settings October 10, 2026 04:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot AI balanced review requested due to automatic review settings October 13, 2026 23:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot AI balanced review requested due to automatic review settings October 14, 2026 23:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The unresolved credential-forwarding issue and reported cross-platform test failures require correction and human verification.

0 open findings

🧠 Review effort: Balanced

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

@NoriZC NoriZC added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 15, 2026
@NoriZC NoriZC self-assigned this Oct 15, 2026
@x-engineering-agent

x-engineering-agent Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

X Engineering Agent Report

⏳ In progress — X Engineering Agent is reviewing this PR at 7b601a6. This comment will be updated with the results.

Review — Comments

Amanda Nguyen (@amnguye)

Codegen provenance needs correction before merge: both changed AutoRest projects lack a changed generation ID. This is PR-related; the current diff changes generated clients and cmdlets without either project's generate-info.json or durable project-level generator input. Run the approved Codegen flow and commit the complete result rather than editing markers.

Upstream CI

13 completed checks succeeded on this head; there are no CI failures to attribute.

Test validation
  • Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
  • Regression coverage: Not applicable to the changed files.

Author-provided coverage adds create/update assertions for CapacityDetailStatus and blob-prefix output in src/StorageDiscovery/StorageDiscovery.Autorest/test/New-AzStorageDiscoveryWorkspace.Tests.ps1 and Update-AzStorageDiscoveryWorkspace.Tests.ps1, alongside changed recordings. These are not Agent live-test results. After regeneration, rerun those focused suites and verify their request/response recordings retain API 2026-10-01-preview, capacityDetails and prefixConfigurations; regeneration reproducibility and live service behavior were not independently verified.

Repository policy findings
  • Generated code ownership checker (blocking) — generated/StorageDiscovery/StorageDiscovery.Autorest/Az.StorageDiscovery.format.ps1xml:4: Azure PowerShell AutoRest project changed without Codegen regeneration evidence in generated/StorageDiscovery/StorageDiscovery.Autorest/generate-info.json. The marker must contain a changed Codegen generation ID and must not be deleted.
    Remediation: Run the repository's approved Codegen flow for generated/StorageDiscovery/StorageDiscovery.Autorest and include all resulting artifacts, including the changed generated/StorageDiscovery/StorageDiscovery.Autorest/generate-info.json. Do not hand-edit the generation marker.
    Verify: Confirm the Codegen run updates generate-info.json and that the complete regenerated diff is committed.

  • Generated code ownership checker (blocking) — src/StorageDiscovery/StorageDiscovery.Autorest/custom/Az.StorageDiscovery.custom.psm1:3: Azure PowerShell AutoRest project changed without Codegen regeneration evidence in src/StorageDiscovery/StorageDiscovery.Autorest/generate-info.json. The marker must contain a changed Codegen generation ID and must not be deleted.
    Remediation: Run the repository's approved Codegen flow for src/StorageDiscovery/StorageDiscovery.Autorest and include all resulting artifacts, including the changed src/StorageDiscovery/StorageDiscovery.Autorest/generate-info.json. Do not hand-edit the generation marker.
    Verify: Confirm the Codegen run updates generate-info.json and that the complete regenerated diff is committed.

Risk assessment — 23/100 · Low

The Low rating is driven by generated output.

  • Change scope: 90 changed files, 5667 changed lines (+5453 / -214), including 0 production files.
  • Affected components: No production component was identified.
  • Risk drivers: generated output (+12)
  • Regression evidence: No production-code regression-test signal applies.
  • Confidence: Low because no production changed-line evidence was available.
  • Required review: Owning-squad review is recommended before merge.

Posted by x-engineering-agent (Reviewer)

@x-engineering-agent x-engineering-agent Bot added the X Engineering Agent Reviewed Agent reviewed this PR label Oct 16, 2026
@amnguye

Copy link
Copy Markdown
Member Author

NoriZC Could you also make a separate preview branch for this? and we can point to that to merge into instead of main.

@amnguye

Copy link
Copy Markdown
Member Author

NoriZC Also was wondering if your comment on my other PR (ElasticSan), also applied here, and I can make the same changes (since I followed the same workflow)

Copilot AI balanced review requested due to automatic review settings October 17, 2026 01:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Stale generation metadata blocks normal regeneration, and the preview API migration still needs human validation of regenerated cmdlets.

1 open issue

Review effort: Balanced

directory: specification/storagediscovery/Microsoft.StorageDiscovery.Management
commit: 959652aca6777cd5db6fd792be4e52dfbaa122ef
directory: specification\storagediscovery\resource-manager\Microsoft.StorageDiscovery\StorageDiscovery
commit: 8f99c33c108147fcc716e71a764010084fe5d034
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Request X Engineering Agent Ask the agent to triage this issue or review this PR X Engineering Agent Reviewed Agent reviewed this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants