Skip to content

Feature/cloudhealth ga 2026 11 01 - #30288

Open
Andre Bossard (abossard) wants to merge 8 commits into
Azure:mainfrom
abossard:feature/cloudhealth-ga-2026-11-01
Open

Andre Bossard (abossard) wants to merge 8 commits into
Azure:mainfrom
abossard:feature/cloudhealth-ga-2026-11-01

Conversation

@abossard

@abossard Andre Bossard (abossard) commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Tests
️✔️ 18/18

Description

Update to the new CloudHealth API 2026-11-01 Stable

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Signed-off-by: Andre Bossard <anbossar@microsoft.com>
Signed-off-by: Andre Bossard <anbossar@microsoft.com>
Signed-off-by: Andre Bossard <anbossar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 78da2000-2e7d-4791-83b7-ff26628d03ea

# Conflicts:
#	tools/VersionController/MinimalVersion.csv
Copilot AI balanced review requested due to automatic review settings October 13, 2026 15:56
@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The stable API configuration and playback coverage are aligned; only a minor changelog wording correction remains.

1 open finding
What changed in this PR

Updates Az.CloudHealth from the preview API to stable API version 2026-11-01.

Changes:

  • Pins TypeSpec generation and UX metadata to the stable API.
  • Refreshes playback recordings and URI assertions.
  • Sets the GA release floor to 1.0.0.
File Description
tools/​VersionController/​MinimalVersion.csv Sets the CloudHealth GA version floor.
src/​CloudHealth/​CloudHealth/​ChangeLog.md Documents stable API support.
src/​CloudHealth/​CloudHealth.Autorest/​UX/​Microsoft.CloudHealth/​healthmodels.json Updates health model UX metadata.
src/​CloudHealth/​CloudHealth.Autorest/​UX/​Microsoft.CloudHealth/​healthmodels-signaldefinitions.json Updates signal definition metadata.
src/​CloudHealth/​CloudHealth.Autorest/​UX/​Microsoft.CloudHealth/​healthmodels-relationships.json Updates relationship metadata.
src/​CloudHealth/​CloudHealth.Autorest/​UX/​Microsoft.CloudHealth/​healthmodels-entities.json Updates entity metadata.
src/​CloudHealth/​CloudHealth.Autorest/​UX/​Microsoft.CloudHealth/​healthmodels-discoveryrules.json Updates discovery rule metadata.
src/​CloudHealth/​CloudHealth.Autorest/​UX/​Microsoft.CloudHealth/​healthmodels-authenticationsettings.json Updates authentication metadata.
src/​CloudHealth/​CloudHealth.Autorest/​tspconfig.yaml Pins generation to the stable API.
src/​CloudHealth/​CloudHealth.Autorest/​tsp-location.yaml Pins the updated specification commit.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Update-AzMonitorHealthModel.Recording.json Refreshes update playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​New-AzMonitorHealthModelSignalDefinition.Recording.json Refreshes signal creation playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​New-AzMonitorHealthModelDiscoveryRule.Recording.json Refreshes discovery-rule playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​New-AzMonitorHealthModelAuthenticationSetting.Recording.json Refreshes authentication playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​New-AzMonitorHealthModel.Tests.ps1 Updates stable API URI assertions.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Invoke-AzMonitorHealthModelIngestEntityHealthReport.Tests.ps1 Updates ingestion URI assertions.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Invoke-AzMonitorHealthModelIngestEntityHealthReport.Recording.json Refreshes ingestion playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelSignalDefinition.Recording.json Refreshes signal retrieval playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelRelationship.Recording.json Refreshes relationship retrieval data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelEntitySignalRecommendation.Recording.json Refreshes recommendation playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelEntitySignalHistory.Recording.json Refreshes signal-history playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelEntityHistory.Recording.json Refreshes entity-history playback data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelEntityDataAnnotation.Recording.json Refreshes annotation retrieval data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelEntity.Recording.json Refreshes entity retrieval data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelDiscoveryRule.Recording.json Refreshes discovery-rule retrieval data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModelAuthenticationSetting.Recording.json Refreshes authentication retrieval data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Get-AzMonitorHealthModel.Recording.json Refreshes health-model retrieval data.
src/​CloudHealth/​CloudHealth.Autorest/​test/​env.json Updates recorded test resource names.
src/​CloudHealth/​CloudHealth.Autorest/​test/​Add-AzMonitorHealthModelEntityDataAnnotation.Recording.json Refreshes annotation creation data.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/CloudHealth/CloudHealth/ChangeLog.md Outdated
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 13, 2026 18:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The committed generated module still targets the preview API, causing product and playback behavior to disagree with the updated configuration.

1 open finding
1 resolved since last review

🧠 Review effort: Balanced

# Pin the API version. Without this the emitter falls back to the latest
# version declared in main.tsp.
api-version: "2026-09-01-preview"
api-version: "2026-11-01"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure that's a false positive, right? The CI/CD is building it.

Signed-off-by: Andre Bossard <anbossar@microsoft.com>
Copilot AI balanced review requested due to automatic review settings October 13, 2026 18:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The committed generated cmdlets still target the preview API, leaving runtime behavior inconsistent with the new configuration and tests.

1 open finding

🧠 Review effort: Balanced

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

@teresaritorto Teresa Ritorto (teresaritorto) added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 15, 2026
@x-engineering-agent

x-engineering-agent Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

X Engineering Agent Report

⏳ In progress — X Engineering Agent is reviewing this PR at 6141a50. This comment will be updated with the results.

@NoriZC NoriZC self-assigned this Oct 16, 2026
@@ -1,2 +1,3 @@
"Module","Minimal Version"
"Az.CloudHealth","1.0.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a policy preventing newly onboarded services GA in 2 months. Please remove the minimal version defined here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Is the 2 months wait period from the time it has been onboarded in preview, or 2 months after GA date?

@github-actions

Copy link
Copy Markdown

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Signed-off-by: Andre Bossard <anbossar@microsoft.com>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 06:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

No concrete defects remain, but regenerated cmdlet compatibility needs confirmation before approval.

1 open finding

🧠 Review effort: Balanced

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-revision Request X Engineering Agent Ask the agent to triage this issue or review this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants