Skip to content

Changes to support SQL Instance snapshot backup - #30299

Open
iwrinshow wants to merge 5 commits into
Azure:mainfrom
iwrinshow:pschangessqlinst
Open

Changes to support SQL Instance snapshot backup#30299
iwrinshow wants to merge 5 commits into
Azure:mainfrom
iwrinshow:pschangessqlinst

Conversation

@iwrinshow

@iwrinshow iwrinshow commented Oct 15, 2026 •
edited by x-engineering-agent Bot
Loading

Copy link
Copy Markdown
Member

🤖 PR Validation — ❌ Action needed

Tests
❌ 22/26
️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Enable-AzRecoveryServicesBackupProtection 2 1 Unassigned_Variable Enable-AzRecoveryServicesBackupProtection -Item $Item is a null-valued parameter value. -Item Assign value for $Item.
⚠️ Enable-AzRecoveryServicesBackupProtection 2 1 Unassigned_Variable Enable-AzRecoveryServicesBackupProtection -Policy $Pol is a null-valued parameter value. -Policy Assign value for $Pol.
⚠️ Enable-AzRecoveryServicesBackupProtection 2 1 Unassigned_Variable Enable-AzRecoveryServicesBackupProtection -VaultId $vault is a null-valued parameter value. -VaultId Assign value for $vault.
⚠️ Get-AzRecoveryServicesBackupRecoveryPoint 4 12 Mismatched_Parameter_Value_Type Set-AzRecoveryServicesBackupProtectionPolicy -RetentionPolicy $pol.RetentionPolicy is not an expected parameter value type. -RetentionPolicy Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RetentionPolicyBase. Now the type is .(Command).
⚠️ Get-AzRecoveryServicesBackupRecoveryPoint 4 18 Mismatched_Parameter_Value_Type Compare-Object -[-ReferenceObject] $rpsBefore is not an expected parameter value type. $rpsBefore Use correct parameter value type. Expected Type is psobject. Now the type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RecoveryPointBase.(Command).
⚠️ Get-AzRecoveryServicesBackupRecoveryPoint 4 18 Mismatched_Parameter_Value_Type Compare-Object -[-DifferenceObject] $rpsAfter is not an expected parameter value type. $rpsAfter Use correct parameter value type. Expected Type is psobject. Now the type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RecoveryPointBase.(Command).
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 1 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -Item $SQLBkpItem is a null-valued parameter value. -Item Assign value for $SQLBkpItem.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 1 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -[-StartDate] $startdate is a null-valued parameter value. $startdate Assign value for $startdate.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 1 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -[-EndDate] $enddate is a null-valued parameter value. $enddate Assign value for $enddate.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -Item $SQLBkpItem is a null-valued parameter value. -Item Assign value for $SQLBkpItem.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -[-StartDate] $startdate is a null-valued parameter value. $startdate Assign value for $startdate.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -[-EndDate] $enddate is a null-valued parameter value. $enddate Assign value for $enddate.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -TargetItem $SQLProtItem is a null-valued parameter value. -TargetItem Assign value for $SQLProtItem.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -TargetContainer $targetVMContainer is a null-valued parameter value. -TargetContainer Assign value for $targetVMContainer.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 3 1 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -RecoveryPoint $snapRp is a null-valued parameter value. -RecoveryPoint Assign value for $snapRp.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 3 1 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -UserAssignedIdentityId $uamiId is a null-valued parameter value. -UserAssignedIdentityId Assign value for $uamiId.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 3 1 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 3 9 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 4 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -RetentionPolicy $retPol is a null-valued parameter value. -RetentionPolicy Assign value for $retPol.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 4 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -SchedulePolicy $schPol is a null-valued parameter value. -SchedulePolicy Assign value for $schPol.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 4 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 5 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 5 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -RetentionPolicy $retPol is a null-valued parameter value. -RetentionPolicy Assign value for $retPol.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 5 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -SchedulePolicy $schPol is a null-valued parameter value. -SchedulePolicy Assign value for $schPol.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 6 23 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Enable-AzRecoveryServicesBackupProtection 2 1 Unassigned_Variable Enable-AzRecoveryServicesBackupProtection -Item $Item is a null-valued parameter value. -Item Assign value for $Item.
⚠️ Enable-AzRecoveryServicesBackupProtection 2 1 Unassigned_Variable Enable-AzRecoveryServicesBackupProtection -Policy $Pol is a null-valued parameter value. -Policy Assign value for $Pol.
⚠️ Enable-AzRecoveryServicesBackupProtection 2 1 Unassigned_Variable Enable-AzRecoveryServicesBackupProtection -VaultId $vault is a null-valued parameter value. -VaultId Assign value for $vault.
⚠️ Get-AzRecoveryServicesBackupRecoveryPoint 4 12 Mismatched_Parameter_Value_Type Set-AzRecoveryServicesBackupProtectionPolicy -RetentionPolicy $pol.RetentionPolicy is not an expected parameter value type. -RetentionPolicy Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RetentionPolicyBase. Now the type is .(Command).
⚠️ Get-AzRecoveryServicesBackupRecoveryPoint 4 18 Mismatched_Parameter_Value_Type Compare-Object -[-ReferenceObject] $rpsBefore is not an expected parameter value type. $rpsBefore Use correct parameter value type. Expected Type is psobject. Now the type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RecoveryPointBase.(Command).
⚠️ Get-AzRecoveryServicesBackupRecoveryPoint 4 18 Mismatched_Parameter_Value_Type Compare-Object -[-DifferenceObject] $rpsAfter is not an expected parameter value type. $rpsAfter Use correct parameter value type. Expected Type is psobject. Now the type is Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models.RecoveryPointBase.(Command).
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 1 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -Item $SQLBkpItem is a null-valued parameter value. -Item Assign value for $SQLBkpItem.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 1 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -[-StartDate] $startdate is a null-valued parameter value. $startdate Assign value for $startdate.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 1 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -[-EndDate] $enddate is a null-valued parameter value. $enddate Assign value for $enddate.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -Item $SQLBkpItem is a null-valued parameter value. -Item Assign value for $SQLBkpItem.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -[-StartDate] $startdate is a null-valued parameter value. $startdate Assign value for $startdate.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupRecoveryPoint -[-EndDate] $enddate is a null-valued parameter value. $enddate Assign value for $enddate.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -TargetItem $SQLProtItem is a null-valued parameter value. -TargetItem Assign value for $SQLProtItem.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 1 2 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -TargetContainer $targetVMContainer is a null-valued parameter value. -TargetContainer Assign value for $targetVMContainer.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 3 1 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -RecoveryPoint $snapRp is a null-valued parameter value. -RecoveryPoint Assign value for $snapRp.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 3 1 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -UserAssignedIdentityId $uamiId is a null-valued parameter value. -UserAssignedIdentityId Assign value for $uamiId.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 3 1 Unassigned_Variable Get-AzRecoveryServicesBackupWorkloadRecoveryConfig -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️ Get-AzRecoveryServicesBackupWorkloadRecoveryConfig 3 9 Unassigned_Variable Restore-AzRecoveryServicesBackupItem -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 4 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -RetentionPolicy $retPol is a null-valued parameter value. -RetentionPolicy Assign value for $retPol.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 4 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -SchedulePolicy $schPol is a null-valued parameter value. -SchedulePolicy Assign value for $schPol.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 4 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 5 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 5 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -RetentionPolicy $retPol is a null-valued parameter value. -RetentionPolicy Assign value for $retPol.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 5 1 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -SchedulePolicy $schPol is a null-valued parameter value. -SchedulePolicy Assign value for $schPol.
⚠️ New-AzRecoveryServicesBackupProtectionPolicy 6 23 Unassigned_Variable New-AzRecoveryServicesBackupProtectionPolicy -VaultId $vault.ID is a null-valued parameter value. -VaultId Assign value for $vault.ID.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Test
❌PowerShell Core - Linux
❌PowerShell Core - MacOS
❌PowerShell Core - Windows
❌Windows PowerShell - Windows
️✔️Az.RecoveryServices.Backup
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Iwrin Show and others added 5 commits October 13, 2026 22:37
Iwrin Show
SQL Instance snapshot backup support
003d5de
Iwrin Show
Fix SQL Instance snapshot policy tiering and add log-chain snapshot f…
163ed11 
…ilters
Iwrin Show
restore config related fixes
75b4f8a
Iwrin Show
Regenerate Backup SDK from merged spec PR #47153 and reconcile
c51c1d4 
Regenerated RecoveryServices.Backup.Management.Sdk from the merged azure-rest-api-specs PR #47153 (RecoveryServicesBackup 2026-10-01, SQL Instance snapshot backup/restore; commit 6f8edbbe9c190be0e4d61c0018503a406dccbd11).

- Updated the SDK README commit pin to the merged PR.
- Reconciled hand-written code with the regenerated SDK: RecoveryPointTierType is now a static string class (changed GetServiceClientRecoveryPointTier return type to string); AzureVmWorkloadProtectionPolicy uses VMWorkloadPolicyType.
- Preserved service-supported fields not yet in the stable 2026-10-01 swagger (BmsrpQueryObject.RecoveryMode query filter, TargetRestoreInfo.TargetDirectoryMapping) as an isolated, regeneration-safe partial-class customization.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Iwrin Show
Merge remote-tracking branch 'origin/main' into pschangessqlinst
cf87bf0 
# Conflicts:
#	src/RecoveryServices/RecoveryServices/ChangeLog.md
Copilot AI balanced review requested due to automatic review settings October 15, 2026 09:23
@azure-pipelines

azure-pipelines Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI reviewed Oct 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

3 open findings
What changed in this PR

Adds SQL Instance snapshot backup and restore support to Az.RecoveryServices.

Changes:

  • Adds instance protection, snapshot policies, restore configuration, and recovery-point filtering.
  • Extends models, conversions, and managed-identity resolution.
  • Upgrades the Backup SDK to API version 2026-10-01 and updates user documentation.
File Description
src/​RecoveryServices/​RecoveryServices/​help/​Register-AzRecoveryServicesBackupContainer.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​help/​New-AzRecoveryServicesBackupProtectionPolicy.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​help/​Get-AzRecoveryServicesBackupWorkloadRecoveryConfig.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​help/​Get-AzRecoveryServicesBackupSchedulePolicyObject.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​help/​Get-AzRecoveryServicesBackupRetentionPolicyObject.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​help/​Get-AzRecoveryServicesBackupRecoveryPoint.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​help/​Get-AzRecoveryServicesBackupItem.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​help/​Enable-AzRecoveryServicesBackupProtection.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​help/​Backup-AzRecoveryServicesBackupItem.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices/​ChangeLog.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​RecoveryServices.Backup.format.ps1xml Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​ParamHelpMsgs.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​Cmdlets/​RecoveryPoint/​GetAzureRmRecoveryServicesBackupRecoveryPoint.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​Cmdlets/​RecoveryPoint/​GetAzureRmRecoveryServicesBackupRecoveryLogChain.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​Cmdlets/​ProtectionPolicy/​NewAzureRmRecoveryServicesBackupProtectionPolicy.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​Cmdlets/​ProtectionPolicy/​GetAzureRmRecoveryServicesBackupSchedulePolicyObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​Cmdlets/​ProtectionPolicy/​GetAzureRmRecoveryServicesBackupRetentionPolicyObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​Cmdlets/​Item/​GetAzureRmRecoveryServicesBackupItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​Cmdlets/​Item/​EnableAzureRmRecoveryServicesBackupProtection.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup/​Cmdlets/​Container/​RegisterAzureRmRecoveryServicesBackupContainer.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.ServiceClientAdapter/​RMAPIs/​ResourceAPIs.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Providers/​PsBackupProviderManager.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Providers/​AzureWorkloadProviderHelper.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​Properties/​Resources.resx Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​Properties/​Resources.Designer.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​CommonModels/​Utils.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​CommonModels/​Enums.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​CmdletParamEnums.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​AzureVmWorkloadModels/​AzureWorkloadSQLInstanceProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​AzureVmWorkloadModels/​AzureWorkloadSQLDatabaseProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​AzureVmWorkloadModels/​AzureWorkloadRecoveryPoint.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Models/​AzureVmWorkloadModels/​AzureWorkloadRecoveryConfig.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​README.md Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​RecoveryServicesBackupClient.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​RecoveryPointsOperationsExtensions.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​ProtectionContainerRefreshOperationStatusesOperationsExtensions.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​WorkloadType.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​VMWorkloadPolicyType.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​ValidateAzureWorkloadRestoreOperationRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​StorageSpaceInfo.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​SnapshotRestoreParameters.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​SnapshotRecoveryPointInfo.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RPExtendedInfoResourceList.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RPExtendedInfoResource.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RPExtendedInfo.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RestorePointQueryType.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RecoveryPointTierType.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RecoveryPointTierInformationV2.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RecoveryPointTierInformation.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RecoveryPointsGetRpExtendedInfoOperationResultHeaders.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​RecoveryPointsGetRpExtendedInfoHeaders.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​ProtectionPolicyQueryObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​ProtectionLevel.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​ProtectedItemQueryObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​ProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​PreValidateEnableBackupRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​MoveRPAcrossTiersRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​MabJob.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​MabFileFolderProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​MabContainerExtendedInfo.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​InstanceProtectionReadiness.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​IaasVmrpExtendedInfo.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​GetRPExtendedInfoRequestResource.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​GetRPExtendedInfoRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​GenericProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​FilesystemInfo.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​FetchTieringCostSavingsInfoForVaultRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​FetchTieringCostSavingsInfoForProtectedItemRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​FetchTieringCostSavingsInfoForPolicyRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​FetchTieringCostInfoRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​FetchTieringCostInfoForRehydrationRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​ExistingBasicVMProtection.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​DPMProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​DiskInformation.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​DiskInfo.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​DataSourceType.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​DatabaseInRP.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​BMSWorkloadItemQueryObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​BMSRPQueryObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​BMSRefreshContainersQueryObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​BMSPOQueryObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​BMSContainersInquiryQueryObject.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​BackupStatusRequest.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​BackupItemType.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureWorkloadSQLRecoveryPointExtendedInfo.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureWorkloadContainer.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureVmWorkloadSQLDatabaseProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureVmWorkloadSAPHanaDBInstanceProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureVmWorkloadSAPHanaDatabaseProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureVmWorkloadSAPAseDatabaseProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureVmWorkloadProtectionPolicy.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureVmWorkloadProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureVMAppContainerProtectionContainer.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureSqlProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureSQLAGWorkloadContainerProtectionContainer.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureIaaSVMProtectionPolicy.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureIaaSVMProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureIaaSComputeVMProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureIaaSClassicComputeVMProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureFileShareProtectionPolicy.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​Models/​AzureFileshareProtectedItem.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​IRecoveryServicesBackupClient.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​IRecoveryPointsOperations.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Generated/​IProtectionContainerRefreshOperationStatusesOperations.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Management.Sdk/​Customizations/​SnapshotRestoreCustomizations.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Helpers/​ServiceClientHelpers.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Helpers/​Conversions/​SubPolicyConversions.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Helpers/​Conversions/​RecoveryPointConversions.cs Updated as part of this pull request.
src/​RecoveryServices/​RecoveryServices.Backup.Helpers/​Conversions/​ConversionHelpers.cs Updated as part of this pull request.
Files not reviewed (1)
  • src/RecoveryServices/RecoveryServices.Backup.Models/Properties/Resources.Designer.cs: Generated file

🧠 Review effort: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .../RecoveryServices.Backup/Cmdlets/Container/RegisterAzureRmRecoveryServicesBackupContainer.cs
{ ContainerParams.BackupManagementType, BackupManagementType.ToString() },
{ ContainerParams.Container, Container},
{ ContainerParams.ResourceGroupName, vmResourceGroupParsed },
{ ContainerParams.ContainerSubscriptionId, ContainerSubscriptionId },
Comment thread src/RecoveryServices/RecoveryServices.Backup.Helpers/Conversions/ConversionHelpers.cs
Comment on lines +909 to +910
if (string.Compare(subProtectionPolicy.PolicyType, "Full") == 0 ||
string.Compare(subProtectionPolicy.PolicyType, "SnapshotFull") == 0)
Comment thread ...coveryServices.Backup/Cmdlets/RecoveryPoint/GetAzureRmRecoveryServicesBackupRecoveryPoint.cs
Comment on lines +253 to +255
string workloadQueryType = !string.IsNullOrEmpty(RestorePointQueryType) ?
RestorePointQueryType : "FullAndDifferential";
providerParameters.Add(RecoveryPointParams.RestorePointQueryType, workloadQueryType);
@a0x1ab

Aditya Pujara (a0x1ab) commented Oct 15, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

NoriZC
NoriZC requested changes Oct 16, 2026
View reviewed changes

@NoriZC NoriZC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the ci failures

@NoriZC NoriZC self-assigned this Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026

Copy link
Copy Markdown

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@NoriZC NoriZC NoriZC requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@NoriZC NoriZC

Labels

needs-revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iwrinshow @a0x1ab @NoriZC