Skip to content

[Az.Fleet] Generate Compute Fleet 2026-08-01 GA powershell SDK - #30302

Open
molikkiddmsft wants to merge 3 commits into
Azure:mainfrom
molikkiddmsft:molikkidd/fleet-launch-mode-GA
Open

molikkiddmsft wants to merge 3 commits into
Azure:mainfrom
molikkiddmsft:molikkidd/fleet-launch-mode-GA

Conversation

@molikkiddmsft

@molikkiddmsft molikkiddmsft commented Oct 16, 2026 •

Copy link
Copy Markdown

🤖 PR Validation — ⚠️ Review suggested

Tests
⚠️ 20/20
️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.ComputeFleet
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzComputeFleet Get-AzComputeFleet Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzComputeFleet Get-AzComputeFleet changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzComputeFleetVirtualMachine Get-AzComputeFleetVirtualMachine Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzComputeFleetVirtualMachine Get-AzComputeFleetVirtualMachine changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzComputeFleetVirtualMachineScaleSet Get-AzComputeFleetVirtualMachineScaleSet Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzComputeFleetVirtualMachineScaleSet Get-AzComputeFleetVirtualMachineScaleSet changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzComputeFleet Get-AzComputeFleet Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzComputeFleet Get-AzComputeFleet changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzComputeFleetVirtualMachine Get-AzComputeFleetVirtualMachine Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzComputeFleetVirtualMachine Get-AzComputeFleetVirtualMachine changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzComputeFleetVirtualMachineScaleSet Get-AzComputeFleetVirtualMachineScaleSet Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzComputeFleetVirtualMachineScaleSet Get-AzComputeFleetVirtualMachineScaleSet changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzComputeFleet 4 2 Mismatched_Parameter_Value_Type Get-AzComputeFleet -InputObject $fleet is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IComputeFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IFleet.(Command).
⚠️ Remove-AzComputeFleet 3 2 Mismatched_Parameter_Value_Type Remove-AzComputeFleet -InputObject $fleet is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IComputeFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IFleet.(Command).
⚠️ Get-AzComputeFleet 4 2 Mismatched_Parameter_Value_Type Get-AzComputeFleet -InputObject $fleet is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IComputeFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IFleet.(Command).
⚠️ Remove-AzComputeFleet 3 2 Mismatched_Parameter_Value_Type Remove-AzComputeFleet -InputObject $fleet is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IComputeFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IFleet.(Command).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzComputeFleet 4 2 Mismatched_Parameter_Value_Type Get-AzComputeFleet -InputObject $fleet is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IComputeFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IFleet.(Command).
⚠️ Remove-AzComputeFleet 3 2 Mismatched_Parameter_Value_Type Remove-AzComputeFleet -InputObject $fleet is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IComputeFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IFleet.(Command).
⚠️ Get-AzComputeFleet 4 2 Mismatched_Parameter_Value_Type Get-AzComputeFleet -InputObject $fleet is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IComputeFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IFleet.(Command).
⚠️ Remove-AzComputeFleet 3 2 Mismatched_Parameter_Value_Type Remove-AzComputeFleet -InputObject $fleet is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IComputeFleetIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IFleet.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI balanced review requested due to automatic review settings October 16, 2026 00:50
@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Thank you for your contribution molikkiddmsft! We will review the pull request and get back to you soon.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing playback recordings use the previous API version and cannot match requests generated for the upgraded API.

2 open findings
What changed in this PR

Updates Az.ComputeFleet generation inputs for the newer service API and refreshes module metadata and documentation.

Changes:

  • Advances the TypeSpec revision and API metadata to 2026-08-01.
  • Removes zone-allocation parameters from command help and clarifies examples.
  • Refreshes generation metadata, dependencies, and release notes.
File Description
src/​ComputeFleet/​ComputeFleet/​help/​Update-AzComputeFleet.md Removes parameters and reformats examples.
src/​ComputeFleet/​ComputeFleet/​help/​Set-AzComputeFleet.md Removes parameters and clarifies immutable properties.
src/​ComputeFleet/​ComputeFleet/​help/​Remove-AzComputeFleet.md Reformats example explanation.
src/​ComputeFleet/​ComputeFleet/​help/​New-AzComputeFleet.md Removes parameters and updates examples.
src/​ComputeFleet/​ComputeFleet/​help/​Get-AzComputeFleetVirtualMachineScaleSet.md Reformats example explanations.
src/​ComputeFleet/​ComputeFleet/​help/​Get-AzComputeFleetVirtualMachine.md Reformats example explanation.
src/​ComputeFleet/​ComputeFleet/​ChangeLog.md Adds generation-fix release note.
src/​ComputeFleet/​ComputeFleet/​Az.ComputeFleet.psd1 Updates dependency and generated metadata.
src/​ComputeFleet/​ComputeFleet.sln Refreshes generated project identifier.
src/​ComputeFleet/​ComputeFleet.Autorest/​UX/​Microsoft.AzureFleet/​fleets.json Updates API version.
src/​ComputeFleet/​ComputeFleet.Autorest/​tspconfig.yaml Enables resource-manager lint rules.
src/​ComputeFleet/​ComputeFleet.Autorest/​tsp-location.yaml Advances specification revision.
src/​ComputeFleet/​ComputeFleet.Autorest/​Properties/​AssemblyInfo.cs Adds whitespace only.
src/​ComputeFleet/​ComputeFleet.Autorest/​generate-info.json Refreshes generation identifier.
src/​ComputeFleet/​ComputeFleet.Autorest/​docs/​Update-AzComputeFleet.md Synchronizes syntax and example formatting.
src/​ComputeFleet/​ComputeFleet.Autorest/​docs/​Set-AzComputeFleet.md Synchronizes syntax and example formatting.
src/​ComputeFleet/​ComputeFleet.Autorest/​docs/​Remove-AzComputeFleet.md Reformats example explanation.
src/​ComputeFleet/​ComputeFleet.Autorest/​docs/​New-AzComputeFleet.md Synchronizes syntax and example formatting.
src/​ComputeFleet/​ComputeFleet.Autorest/​docs/​Get-AzComputeFleetVirtualMachineScaleSet.md Reformats example explanations.
src/​ComputeFleet/​ComputeFleet.Autorest/​docs/​Get-AzComputeFleetVirtualMachine.md Reformats example explanation.
src/​ComputeFleet/​ComputeFleet.Autorest/​docs/​Az.ComputeFleet.md Refreshes module identifier.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@@ -1,3 +1,3 @@
directory: specification\azurefleet\resource-manager\Microsoft.AzureFleet\AzureFleet
commit: 0079cf063ea0162adc7b8e0eec7f6e7c7b67ad96
commit: 1249f8e2b407b339083c5125a245bdd3057f6cd5
Comment thread src/ComputeFleet/ComputeFleet/ChangeLog.md
@NoriZC

NoriZC commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

/azp run

@NoriZC NoriZC self-assigned this Oct 16, 2026
@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

@NoriZC NoriZC added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 16, 2026
@x-engineering-agent

x-engineering-agent Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

X Engineering Agent Report

⏳ In progress — X Engineering Agent is reviewing this PR at 58c597e. This comment will be updated with the results.

Review — Comments

molikkiddmsft

ComputeFleet's API upgrade still fails upstream playback. Refresh recordings and disclose public compatibility changes before merge.

Upstream CI

azure-powershell - powershell-core

  • Result: failure
  • Included checks: azure-powershell - powershell-core (Test macOS), azure-powershell - powershell-core (Test windows), azure-powershell - powershell-core (Test linux)
  • Failure details:
    • Test windows / Test (PR-related)
      • Evidence: "ArgumentException: Missing Request 'Update-AzComputeFleet"; "api-version=2026-08-01+1' in recording file (Parameter 'rqKey')"
      • Next action: Re-record Update-AzComputeFleet for API 2026-08-01 and inspect request/response changes; do not substitute version strings.
      • Verify: Run Update-AzComputeFleet playback on this platform, then the ComputeFleet suite.
    • Test linux / Test (PR-related)
      • Evidence: "ArgumentException: Missing Request 'Update-AzComputeFleet"; "api-version=2026-08-01+1' in recording file (Parameter 'rqKey')"
      • Next action: Re-record Update-AzComputeFleet for API 2026-08-01 and inspect request/response changes; do not substitute version strings.
      • Verify: Run Update-AzComputeFleet playback on this platform, then the ComputeFleet suite.
    • Test macOS / Test (PR-related)
      • Evidence: "ArgumentException: Missing Request 'Update-AzComputeFleet"; "api-version=2026-08-01+1' in recording file (Parameter 'rqKey')"
      • Next action: Re-record Update-AzComputeFleet for API 2026-08-01 and inspect request/response changes; do not substitute version strings.
      • Verify: Run Update-AzComputeFleet playback on this platform, then the ComputeFleet suite.

azure-powershell - windows-powershell

  • Result: failure
  • Included checks: azure-powershell - windows-powershell (Test)
  • Failure details:
    • Test / Test (PR-related)
      • Evidence: "ArgumentException: Missing Request 'Update-AzComputeFleet"; "api-version=2026-08-01+1' in recording file (Parameter 'rqKey')"
      • Next action: Re-record Update-AzComputeFleet for API 2026-08-01 and inspect request/response changes; do not substitute version strings.
      • Verify: Run Update-AzComputeFleet playback on this platform, then the ComputeFleet suite.
Test validation
  • Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
  • Regression coverage: Not applicable to the changed files.

The PowerShell coverage helper is not applicable; it does not verify the API-upgrade scenario. No tests or recordings changed. src/ComputeFleet/ComputeFleet.Autorest/test/Update-AzComputeFleet.Tests.ps1 creates fleets in BeforeAll; logs show the new PUT key is absent from Update-AzComputeFleet.Recording.json, so update assertions never execute. Re-record against the new API, then run focused playback and the module suite. Inspect create/update payloads, returned capacity/provisioning state, identity-based update and preserved properties; replacing API-version strings cannot establish compatibility. No Agent live test ran.

Release artifact finding

src/ComputeFleet/ComputeFleet/ChangeLog.md:21 describes tooling only, although ComputeFleet.Autorest/UX/Microsoft.AzureFleet/fleets.json:3 changes the API to 2026-08-01 and generated/published New, Set and Update help removes ZoneAllocationPolicyDistributionStrategy and ZoneAllocationPolicyZonePreference. Document the API upgrade and parameter compatibility impact. Confirm regenerated command metadata and existing-script parameter binding, then regenerate matching help. The changed help establishes documentation removal, not a separately executed binding test.

Both Copilot comments are corroborated: the recording concern by task logs, and the release-note concern by changed metadata/help. They are consolidated above, not duplicate findings.

Risk assessment — 18/100 · Low

The Low rating is driven by no changed regression test.

  • Change scope: 21 changed files, 340 changed lines (+94 / -246), including 1 production file.
  • Affected components: computefleet
  • Risk drivers: no changed regression test (+10)
  • Regression evidence: No changed regression test was detected for the production changes, increasing risk.
  • Confidence: High because changed-line patches were available for every production file.
  • Required review: Owning-squad review is recommended for computefleet before merge.

Posted by x-engineering-agent (Reviewer)

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

@molikkiddmsft molikkiddmsft changed the title initial commit for powershell commands [Az.Fleet] Generate Compute Fleet 2026-08-01 GA powershell SDK Oct 16, 2026
@x-engineering-agent x-engineering-agent Bot added the X Engineering Agent Reviewed Agent reviewed this PR label Oct 16, 2026
Copilot AI balanced review requested due to automatic review settings October 16, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Reported test failures across all four platforms remain unexplained and require investigation before approval.

3 open findings

🧠 Review effort: Balanced

Comment thread src/ComputeFleet/ComputeFleet.Autorest/examples/Update-AzComputeFleet.md Outdated
Copilot AI balanced review requested due to automatic review settings October 16, 2026 21:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Reported test failures across all four platforms leave the breaking API migration insufficiently validated.

1 open issue
1 previously missed issue

In code that hasn't changed since last review

Low severity Revert whitespace-only changes to AssemblyInfo.cs

src/​ComputeFleet/​ComputeFleet.Autorest/​Properties/​AssemblyInfo.cs:32

Please revert this whitespace-only change. tools/StaticAnalysis/FileChangeAnalyzer/Test-FileChange.ps1:62–68 flags every modification to AssemblyInfo.cs, since release automation owns this file; these added blank lines trigger the reported File Change Check warning.

2 resolved since last review

Review effort: Balanced

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Request X Engineering Agent Ask the agent to triage this issue or review this PR X Engineering Agent Reviewed Agent reviewed this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants