Repository navigation
Managed ilasm: do not refer to native ilasm in comments - #135993
Open
pcshrosbree wants to merge 1 commit into
Open
pcshrosbree wants to merge 1 commit into
pcshrosbree wants to merge 1 commit into
Conversation
Comments in the managed ilasm and its tests that described the code by comparing it with native ilasm now state the rule the code follows. One test drops "GiveTheRowsOfNativeIlasm" from its name. Comments and the test name only; no behavior change.
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #135932, @jkotas asked that comments not refer to native ilasm and stand on their own, with one exception: unnatural behavior that is kept for compatibility. This PR applies that to the comments I added in #135311, #135297 and #135289, which are on main.
Where a comment explained the code by comparing it with native ilasm, it now states the rule the code follows. Where the reference was only an aside ("As in native ilasm, ..."), it is removed. None of these comments explained behavior kept for compatibility.
One test,
SlotGapReusedSlotAndShadowedNameInTryAndCatchBodies_GiveTheRowsOfNativeIlasm, is renamed: its suffix becomesGiveARowForEachScope. Nothing else refers to the old name. Apart from that name, only comments change, so there is no behavior change.Twelve such comment lines are not in this PR, because my open PRs change them or the lines next to them:
Note
This change was prepared with AI assistance (Anthropic Claude and OpenAI Codex) under my direction. I reviewed the change before posting.