Repository navigation
sessions: remove unused GitHub reference list - #341995
Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits intoOct 16, 2026
Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits into
Dmitriy Vasyura (dmitrivMS) merged 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The removal is self-contained, with no remaining references reported and unrelated polling coverage preserved.
0 open findings
What changed in this PR
Removes the unused GitHub reference-list component from the Agents Window.
Changes:
- Deletes the component and its dedicated stylesheet.
- Removes component-specific tests and imports while preserving pull-request polling tests.
No actionable findings remain. Build and test validation was blocked by unavailable dependencies.
| File | Description |
|---|---|
src/vs/sessions/contrib/github/test/browser/githubContribution.test.ts |
Removes reference-list tests; retains polling coverage. |
src/vs/sessions/contrib/github/browser/media/githubReferenceList.css |
Deletes component-only styles. |
src/vs/sessions/contrib/github/browser/githubReferenceList.ts |
Deletes the unused component and entry type. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alex Ross (alexr00)
previously approved these changes
Oct 16, 2026
Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Henning Dieterichs (hediet)
approved these changes
Oct 16, 2026
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Aiday Marlen Kyzy (aiday-mar)
approved these changes
Oct 16, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
dmitriv/remove-unused-github-reference-list
branch
October 16, 2026 14:15
Sandeep Somavarapu (sandy081)
added a commit
that referenced
this pull request
Oct 16, 2026
…race Follow-up to #341995, which fixed the older-build check test by waiting for the drain statement's own trace as well as its completion. The 'burst of ten creates or ten deletes' test in the same suite still assumed traces of finished statements arrive before the drain completes. @vscode/sqlite3 delivers trace events through a separate async callback, so its statement count could miss late traces in the same way. Use the same trace-fenced drain as the older-build test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
added a commit
that referenced
this pull request
Oct 16, 2026
…race (#342054) Follow-up to #341995, which fixed the older-build check test by waiting for the drain statement's own trace as well as its completion. The 'burst of ten creates or ten deletes' test in the same suite still assumed traces of finished statements arrive before the drain completes. @vscode/sqlite3 delivers trace events through a separate async callback, so its statement count could miss late traces in the same way. Use the same trace-fenced drain as the older-build test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/microsoft/vscode-internalbacklog/issues/9678
Remove the unused
GitHubReferenceListcomponent, its exclusive stylesheet, and its dedicated tests. The component has no production consumers; the GitHub pull-request polling tests remain intact.