Repository navigation
Conversation
CarlSchwan
force-pushed
the
fix/7935/download-uri-too-long
branch
from
October 8, 2026 15:53
87e9ed2 to
67f9615
Compare
CarlSchwan
marked this pull request as ready for review
October 8, 2026 15:54
CarlSchwan
requested review from
Altahrim,
kristian-zendato,
leftybournes,
pringelmann,
provokateurin and
salmart-dev
and removed request for
a team
October 8, 2026 15:54
pringelmann
reviewed
Oct 9, 2026
| // Send the file list in the request body to avoid too long URLs. | ||
| // A native form submission lets the browser stream the archive to disk. | ||
| const form = document.createElement('form') | ||
| form.method = 'POST' |
Contributor
There was a problem hiding this comment.
Tested locally: zipping a folder that contains a view-only share returns a 403 here. With a form submit, wouldn't the browser end up on that error page instead of staying in Files?
Member
There was a problem hiding this comment.
This is a bit tricky, I will try to figure out a solution
pringelmann
reviewed
Oct 9, 2026
pringelmann
reviewed
Oct 9, 2026
When downloading multiple files as a ZIP archive, filenames were appended to the URL as query parameters, causing "414 Request-URI Too Long" errors with many files. Backend now supports POST requests with files in request body. Frontend sends files via FormData in POST body instead of URL params. Fixes #7935 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Downloading the archive through axios as a blob buffered the whole archive in memory and then failed, as HEAD requests on blob URLs are not allowed. Submit a hidden form instead so the browser streams the download natively. Also reject non-string `files` parameters instead of failing with a TypeError. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/7935/download-uri-too-long
branch
from
October 15, 2026 10:41
67f9615 to
778b469
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading multiple files as a ZIP archive, filenames were appended to the URL as query parameters, causing "414 Request-URI Too Long" errors with many files.
Backend now supports POST requests with files in request body. Frontend sends files via FormData in POST body instead of URL params.
Fixes #7935