Repository navigation
feat: show the source name of the renamed received share - #65158
Merged
Merged
Conversation
kristian-zendato
requested review from
a team and
provokateurin
as code owners
October 6, 2026 06:57
kristian-zendato
requested review from
CarlSchwan,
leftybournes,
skjnldsv,
sorbaugh and
susnux
and removed request for
a team
October 6, 2026 06:57
skjnldsv
reviewed
Oct 6, 2026
kristian-zendato
force-pushed
the
fix/share-rename
branch
from
October 6, 2026 08:51
63e3015 to
ffccdbd
Compare
skjnldsv
approved these changes
Oct 6, 2026
susnux
reviewed
Oct 12, 2026
susnux
reviewed
Oct 12, 2026
susnux
reviewed
Oct 12, 2026
susnux
reviewed
Oct 12, 2026
susnux
reviewed
Oct 12, 2026
kristian-zendato
force-pushed
the
fix/share-rename
branch
from
October 13, 2026 06:41
ffccdbd to
58da9e2
Compare
kristian-zendato
force-pushed
the
fix/share-rename
branch
from
October 13, 2026 07:32
58da9e2 to
89f3006
Compare
susnux
reviewed
Oct 13, 2026
kristian-zendato
force-pushed
the
fix/share-rename
branch
from
October 13, 2026 10:22
89f3006 to
5113f35
Compare
susnux
approved these changes
Oct 13, 2026
susnux
changed the title
Contributor
|
Tests look related? |
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
kristian-zendato
force-pushed
the
fix/share-rename
branch
from
October 14, 2026 11:52
5113f35 to
71c91da
Compare
Contributor
Author
Related tests are fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When someone renames a received share, the sharing sidebar still needs to show the name it had on the source. This adds that name as
original_displaynameon the share API and as thenc:original-displaynameWebDAV property, only for the share root and only when the names differ.The sidebar keeps "Shared with you by {owner}" and appends "originally as {name}" in that case. Public WebDAV does not expose the property.
Checklist
3. to review, feature component)stable32)AI (if applicable)